Change the color for selected Greek words #6

New Issue

Open

opened 2021-04-07 13:25:32 +00:00 by lenrsmith · 5 comments

lenrsmith commented

2021-04-07 13:25:32 +00:00

Contributor

Tim pointed out that the color used for selected Greek words and their corresponding table entry does not have enough contrast.

Current color code: #add8e6

Reproduce: Navigate to any available scripture verse and click on a Greek word.

Tim pointed out that the color used for selected Greek words and their corresponding table entry does not have enough contrast. Current color code: #add8e6 Reproduce: Navigate to any available scripture verse and click on a Greek word.

lenrsmith added the

Enhancement

label 2021-04-07 13:25:41 +00:00

ezra was assigned by lenrsmith

2021-04-07 13:25:50 +00:00

ezra commented

2021-04-07 16:04:44 +00:00

Member

Does it need to be the same color as the highlighting in the table? If so, we'll probably need to change the text color in the table when highlighted to white instead of black to provide proper contrast.

Does it need to be the same color as the highlighting in the table? If so, we'll probably need to change the text color in the table ***when highlighted*** to white instead of black to provide proper contrast.

lenrsmith commented

2021-04-07 16:37:50 +00:00

Author

Contributor

I think having them the same color will help the user make the connection between the two datasets.

👍 1

ezra commented

2021-04-07 17:08:03 +00:00

Member

How about highlighting the word in the verse with background-color instead of changing the color of the text? I think that makes an even closer connection, and doesn't require any changes in font colors. I'll push that change so you can see what you think.

How about highlighting the word in the verse with `background-color` instead of changing the color of the text? I think that makes an even closer connection, and doesn't require any changes in font colors. I'll push that change so you can see what you think.

lenrsmith commented

2021-04-07 17:11:24 +00:00

Author

Contributor

I am good with whatever you think will work best. Feel free to make changes. We can always rever them if we change our minds.

ezra commented

2021-04-30 22:03:39 +00:00

Member

This should be fixed with commit 6f84a4c61c

This should be fixed with commit [6f84a4c61c](https://content.bibletranslationtools.org/WycliffeAssociates/en_btr_frontend/commit/6f84a4c61c42a56ff033a78391c627cbc993db64)